Use pre-defined arguments to support override symlink prefix and append targets #113
Conversation
- Override symlink: bazel run @hedron_compile_commands//:refresh_all -- --bazel-out=mypredix- - Append targets: Only parser //foo:foo target and append to existing compile commands. bazel run @hedron_compile_commands//:refresh_all -- -t "//foo"
|
Hello again, @LoSealL! Great to hear from you. I hear you on both needs. On the faster, incremental update: I totally get that for very large codebases, rerunning the whole thing is too slow. (There are the usual speed tricks in the README, but it sounds like those are insufficient.) There's a trap if you do it per-sub-target, though, and that's that the top-level-target often configures the targets it depends on, meaning that the commands for the sub targets are wrong if you ask for them the obvious way 🤦🏻. Cross-compiling, e.g. to mobile or embedded, is a key example of this. You'll get commands for the host platform, not the target platform. Plus, getting all dependencies of a sub-target can still be overwhelming. So instead, I've been working with @xinzhengzhang for a while on a Does that sound like it'd solve things for you too? If so, we could really use your help, double checking that it works for you and resolving some of the remaining TODOs in the code. (Am I right in remembering that you'd helped with windows before? If so, there are some bite-sized windows TODOs we could really use your help on.) The work is going on in #99 with the early design discussion in #93. If you're down to help, I'm hoping he can just give you commit access the branch we're using for the feature. For Bazel-out: Cheers--and thanks for being the kind of person that looks for ways to help improve things! |
|
Thanks for taking a look, and being down to merge efforts @LoSealL. Please let me know what you think. And for my learning, what does BR stand for? |
|
Best regards :-) |
Problem statement
Currently
bazel-compile-commands-extractorworks very well in most cases, but there are still some rare cases where users may specify a different output directory other than the default"bazel-*".On the other hand, if users add some new source files and want clangd to index them, they probably do not want to re-run the whole extractor, especially when users add new files frequently (usually at the beginning of a project or adding new features to an existing project), just because a total re-run takes quite a few miniutes.
Solution
Hence we propose a PR to solve above two problems:
We add explicit argument parser to parse two pre-defined arguments:
"-b", "--bazel-out"and"-t", "--targets":